Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added blog url and campaign / social short link tracking #145

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

feat: added blog url and campaign / social short link tracking #145

wants to merge 11 commits into from

Conversation

Tguntenaar
Copy link
Collaborator

@Tguntenaar Tguntenaar commented Aug 20, 2024 •
edited
Loading

Resolves #879

This PR does two things:

  • Adds match pattern for the blog links (blogv2)
  • Adds mapping for query parameters that track campaign and social for Joe

We want links like this: /blog/dev-dao/blog-title?c=1&s=i to work. Mapping is defined in this spreadsheet

NOTE: The request.query hashmap is always empty.. So I'm going to parse it from the path request: Web4Request

EDIT: After review I removed any hardcoded mapping from the contract and we will do it manually in posthog instead.

@Tguntenaar Tguntenaar requested a review from frol August 21, 2024 20:31
@Tguntenaar Tguntenaar marked this pull request as ready for review August 21, 2024 20:31
frol
frol requested changes Aug 22, 2024
View reviewed changes
Copy link
Collaborator

@frol frol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not flexible to maintain the list of campaigns inside the contract. Just parse out all the query arguments from the URL (?<query_args>) and append them to the constructed redirect URL (&<query_args>)

@Tguntenaar
Copy link
Collaborator Author

@frol could you review it one more time?

frol
frol reviewed Sep 4, 2024
View reviewed changes
src/web4/handler.rs Outdated Show resolved Hide resolved
src/web4/handler.rs Show resolved Hide resolved
src/web4/handler.rs Outdated Show resolved Hide resolved
@Tguntenaar
Copy link
Collaborator Author

@race-of-sloths include

@race-of-sloths-bot
Copy link

@Tguntenaar Thank you for your contribution! Your pull request is now a part of the Race of Sloths!

Shows inviting banner with latest news.

Shows profile picture for the author of the PR

Current status: waiting for scoring

We're waiting for maintainer to score this pull request with @race-of-sloths score [0,1,2,3,5,8,13] command. Alternatively, autoscoring [1,2] will be applied for this pull request

What is the Race of Sloths

Race of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow

For contributors:

  • Tag @race-of-sloths inside your pull requests
  • Wait for the maintainer to review and score your pull request
  • Check out your position in the Leaderboard
  • Keep weekly and monthly streaks to reach higher positions
  • Boast your contributions with a dynamic picture of your Profile

For maintainers:

  • Score pull requests that participate in the Race of Sloths
  • Engage contributors with fair scoring and fast responses so they keep their streaks
  • Promote the Race to the point where the Race starts promoting you
  • Grow the community of your contributors

Feel free to check our website for additional details!

Bot commands
  • For contributors
    • Include a PR: @race-of-sloths include to enter the Race with your PR
  • For maintainers:
    • Invite contributor @race-of-sloths invite to invite the contributor to participate in a race or include it, if it's already a runner.
    • Assign points: @race-of-sloths score [1/2/3/5/8/13] to award points based on your assessment.
    • Reject this PR: @race-of-sloths exclude to send this PR back to the drawing board.
    • Exclude repo: @race-of-sloths pause to stop bot activity in this repo until @race-of-sloths unpause command is called

@race-of-sloths
Copy link

race-of-sloths commented Oct 25, 2024 •
edited
Loading

@Tguntenaar Thank you for your contribution! Your pull request is now a part of the Race of Sloths!
Weekly streak is on the road, smart strategy! Secure your streak with another PR!

Shows inviting banner with latest news.

Shows profile picture for the author of the PR

Current status: stale

This pull request was removed from the race, but you can include it again with @race-of-sloths include command

What is the Race of Sloths

Race of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow

For contributors:

  • Tag @race-of-sloths inside your pull requests
  • Wait for the maintainer to review and score your pull request
  • Check out your position in the Leaderboard
  • Keep weekly and monthly streaks to reach higher positions
  • Boast your contributions with a dynamic picture of your Profile

For maintainers:

  • Score pull requests that participate in the Race of Sloths
  • Engage contributors with fair scoring and fast responses so they keep their streaks
  • Promote the Race to the point where the Race starts promoting you
  • Grow the community of your contributors

Feel free to check our website for additional details!

Bot commands
  • For contributors
    • Include a PR: @race-of-sloths include to enter the Race with your PR
  • For maintainers:
    • Invite contributor @race-of-sloths invite to invite the contributor to participate in a race or include it, if it's already a runner.
    • Assign points: @race-of-sloths score [1/2/3/5/8/13] to award points based on your assessment.
    • Reject this PR: @race-of-sloths exclude to send this PR back to the drawing board.
    • Exclude repo: @race-of-sloths pause to stop bot activity in this repo until @race-of-sloths unpause command is called

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frol frol frol requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve User Referral and Journey Tracking in PostHog
4 participants
@Tguntenaar @race-of-sloths-bot @race-of-sloths @frol